cmake build rework #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabrain34
force-pushed
the
dab_cmake_build_rework
branch
from
8a763a2
to
251c363
Compare
zlatinski
approved these changes
Oct 18, 2024
zlatinski
reviewed
Oct 18, 2024
dabrain34
force-pushed
the
dab_cmake_build_rework
branch
from
251c363
to
ecb922b
Compare
zlatinski
approved these changes
Nov 9, 2024
Signed-off-by: Stéphane Cerveau <[email protected]>
|
I just tested today on Windows and unfortunately the build is failing. Investigating.. |
dabrain34
force-pushed
the
dab_cmake_build_rework
branch
from
ecb922b
to
8c529d3
Compare
Add a common Cmake file to build encoder/decoder projects. Signed-off-by: Stéphane Cerveau <[email protected]>
Signed-off-by: Stéphane Cerveau <[email protected]>
Signed-off-by: Stéphane Cerveau <[email protected]>
dabrain34
force-pushed
the
dab_cmake_build_rework
branch
from
8c529d3
to
78c02a6
Compare
|
This is now building on both Windows and Linux. I moved the generate_dispatch_table to a common place to be generated only once. |
dabrain34
force-pushed
the
dab_cmake_build_rework
branch
from
78c02a6
to
e9d3856
Compare
zlatinski
approved these changes
Nov 12, 2024
zlatinski
approved these changes
Nov 12, 2024
zlatinski
approved these changes
Nov 12, 2024
zlatinski
approved these changes
Nov 12, 2024
zlatinski
approved these changes
Nov 12, 2024
zlatinski
approved these changes
Nov 12, 2024
|
I'm wondering if it would make sense to have a vkCodecUtils static library with:
What do you think @zlatinski ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factorize the build of vk_video_samples to one CMakefile containing the definitions for both decoder and encoder
project.
Can now enable disable the build of encoder/decoder by a CMake option.